Set ODE_WITH_LIBCCD_BOX_CYL to OFF for consistency with autotools builds used in Linux distributions #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
1 task
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libode-feedstock/actions/runs/8340444472. |
traversaro
changed the title
This was referenced Mar 19, 2024
jslee02
referenced
this pull request
in dartsim/dart
Mar 29, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many major Linux distributions build ode with autotools, while in conda-forge we build it with CMake.
In ode there is a subtle difference between autotools and CMake builds, documented in conda-forge/dartsim-feedstock#62 and https://bitbucket.org/odedevs/ode/issues/87/box-cylinder-ccd-check-disabled-by-default .
To make the conda-forge package of ode behave like most users probably expect, we set the CMake options to ensure that the build behaves like the autotools build, a bit like in #22 we enable the ccd dependency.
Fix conda-forge/dartsim-feedstock#63 .
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)